Exclude GenerateJLIClassesPluginTest for openJ9 implementation #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is not applicable to openj9 implementation Signed-off-by: Sophia Guo <[email protected]>
|
Thanks Sophia! Presumably, there will be one additional change, where in the playlist we reference this exclude file in the jdk_tools test case for openj9 (but agree that can come in a later PR, when we actually enable that group of tests for that implementation. |
smlambert
approved these changes
Jan 10, 2018
|
@ShelleyLambert I may not get your point. Currently each test case jdk_*** are referenced to specific exclude file by JVM_VERSION( for openj9 is openjdk8/9-openj9):
|
|
ah great, my mistake, I did not see we were already doing that here (thought the change was only in the openj9 repo), thanks @sophia-guo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is not applicable to openj9 implementation
close #206
Signed-off-by: Sophia Guo [email protected]